Fix.simulation mode started bug #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.simulation_mode_started_bug
branch
from
9453fb9
to
28f4475
Compare
oliver-sanders
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM.
This is a bug (note just a shortcoming in simulation mode) because (as Tim noted) the DB lists the "started" output, but the downstream task is never triggered which is inconsistent.
I did wonder whether this should be fixed by getting the submit code to send the started output like so:
diff --git a/cylc/flow/task_job_mgr.py b/cylc/flow/task_job_mgr.py
index 185966ff1..7a6451605 100644
--- a/cylc/flow/task_job_mgr.py
+++ b/cylc/flow/task_job_mgr.py
@@ -1028,6 +1028,9 @@ class TaskJobManager:
self.task_events_mgr.process_message(
itask, INFO, TASK_OUTPUT_SUBMITTED,
)
+ self.task_events_mgr.process_message(
+ itask, INFO, TASK_OUTPUT_STARTED,
+ )
self.workflow_db_mgr.put_insert_task_jobs(
itask, {
'time_submit': now_str,But quickly realised why we don't do that:
ERROR - 'execution polling intervals'
Traceback (most recent call last):
...
KeyError: 'execution polling intervals'
This makes Cylc think that there is actually a job running, it tries to setup health checks which fail for obvious reasons.
hjoliver
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
LGTM. Not merging in case @oliver-sanders comment requires a small change?
wxtim
commented
Sep 4, 2024
wxtim
force-pushed
the
fix.simulation_mode_started_bug
branch
from
a8c153e
to
650f987
Compare
|
@oliver-sanders - final check that you are happy with my response to your comment? |
|
Not sure which one, but yes I'm happy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered by @oliver-sanders in the process of reviewing skip mode work (#6039 (comment)). The bug however, is long-standing (it goes back at least as far as Cylc 8.0.0.
Summary
In simulation mode, job starting is done by the job submission pathway as a side-effect (because in sim mode the two might as well be identical). However, the pathway is not currently spawning children of started.
Example
Run this
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.